Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • ♻️ introduce webserver 4 tests

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 4, 2024 15:31
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 4, 2024
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Nov 4, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 4, 2024
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (24445c0) to head (f44baa5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6663      +/-   ##
==========================================
- Coverage   87.87%   85.84%   -2.04%     
==========================================
  Files        1563      609     -954     
  Lines       62881    30889   -31992     
  Branches     2088      265    -1823     
==========================================
- Hits        55258    26517   -28741     
+ Misses       7305     4311    -2994     
+ Partials      318       61     -257     
Flag Coverage Δ
integrationtests 64.83% <ø> (+0.01%) ⬆️
unittests 87.79% <ø> (+1.82%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 90.85% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.72% <ø> (-30.00%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 89.31% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24445c0...f44baa5. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 4, 2024 15:52
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@matusdrobuliak66 matusdrobuliak66 merged commit 7d52bf7 into ITISFoundation:master Nov 4, 2024
86 of 89 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants