Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 5, 2024

What do these changes do?

  • ♻️ Marks new web API entrypoints in ✨ Trash projects #6579 as dev features i.e. can only be used with WEBSERVER_DEV_FEATURES_ENABLED=1. This way it is not released to production.
  • 🔨 updates .codecov.yaml to avoid false positives in CI

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/03/test_trash.py

Dev-ops checklist

None

@pcrespov pcrespov self-assigned this Nov 5, 2024
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Nov 5, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Nov 5, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

@pcrespov pcrespov changed the title Is468/mark trash api as dev ♻️ Mark new trash web-api as dev-features Nov 5, 2024
@pcrespov pcrespov enabled auto-merge (squash) November 5, 2024 09:08
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks a lot

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.74%. Comparing base (cba3237) to head (3e74bb3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6665      +/-   ##
==========================================
- Coverage   87.97%   85.74%   -2.23%     
==========================================
  Files        1568      613     -955     
  Lines       63362    31348   -32014     
  Branches     2089      265    -1824     
==========================================
- Hits        55740    26878   -28862     
+ Misses       7304     4409    -2895     
+ Partials      318       61     -257     
Flag Coverage Δ
integrationtests 64.81% <100.00%> (-0.13%) ⬇️
unittests 86.82% <100.00%> (+0.96%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 90.11% <ø> (-0.61%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.69% <ø> (-30.03%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.68% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 89.31% <100.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba3237...3e74bb3. Read the comment docs.

@pcrespov pcrespov merged commit cddaab9 into ITISFoundation:master Nov 5, 2024
84 of 89 checks passed
@pcrespov pcrespov deleted the is468/mark-trash-api-as-dev branch November 5, 2024 09:37
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants