-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fixed packages mypy, pylint and tests #6678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed packages mypy, pylint and tests #6678
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6678 +/- ##
===============================================================================
+ Coverage 72.29% 74.47% +2.18%
===============================================================================
Files 1038 1184 +146
Lines 44897 47163 +2266
Branches 1316 1528 +212
===============================================================================
+ Hits 32457 35124 +2667
+ Misses 12209 11818 -391
+ Partials 231 221 -10
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few things that are strange. Also setting models to have optional fields has consequences. I would like to check the one with the progress bar at least
packages/models-library/src/models_library/api_schemas_directorv2/comp_tasks.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_dynamic_sidecar/telemetry.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_dynamic_sidecar/telemetry.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/projects.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_storage.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/service_settings_labels.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/dbmanager.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_endpoint.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_directorv2/comp_tasks.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_dynamic_sidecar/telemetry.py
Show resolved
Hide resolved
…quash_updates' into pr-osparc-pydantic2-fixes-to-libraries2
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check ClusterCreate. thanks for the other changes.
packages/models-library/src/models_library/api_schemas_directorv2/clusters.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_directorv2/comp_tasks.py
Outdated
Show resolved
Hide resolved
…quash_updates' into pr-osparc-pydantic2-fixes-to-libraries2
|
f07afbf
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates


What do these changes do?
Made packages tests green.
Related issue/s
How to test
Dev-ops checklist