Skip to content

🎨 [Frontend] Enhance: syncing tree #6687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 8, 2024
Merged

🎨 [Frontend] Enhance: syncing tree #6687

merged 15 commits into from
Nov 8, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 7, 2024 •
edited
Loading

What do these changes do?

There were a couple of glitches syncing the tree when the tree was completely empty (no folders, no shared workspaces). This PR fixes them.

Bonus:

  • Organizations management: Show backend's error message if any
  • In the Service information view, when only the description is visible, show also the Copy study and service Id buttons

SyncTree

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 7, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 7, 2024
@odeimaiz odeimaiz self-assigned this Nov 7, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) November 7, 2024 15:43
sanderegg
sanderegg reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHK
GitHK reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sanderegg sanderegg disabled auto-merge November 8, 2024 12:21
@sanderegg sanderegg merged commit 1564d50 into ITISFoundation:master Nov 8, 2024
51 checks passed
@odeimaiz odeimaiz deleted the fix/sync-tree branch November 8, 2024 12:27
This was referenced Nov 11, 2024
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@ignapas ignapas Awaiting requested review from ignapas

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

Improvements/fixes on the workflow to create organizations

5 participants

@odeimaiz @GitHK @pcrespov @sanderegg @matusdrobuliak66