Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 8, 2024

What do these changes do?

ReDoc Swagger UI
image

web-api offers new operations to trash workspaces

Highlights

  • ✨ web api 0.45.0 → 0.46.0 changes:
    • adds trash as POST /workspace/{workspace_id}:trash
    • adds untrash as POST /workspace/{workspace_id}:untrash
    • list_workpaces adds filters query
    • WorkspaceGet adds optional trashed_at and trashed_by
  • 🗃️ adds trash attributes to workspaces table
  • 🎨 ♻️ cleanup workspaces plugin: modules, schemas, oas-generators and exception handling

Next steps

  • extend trashed_by to projects and folders
  • unit-of-work across api

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/**/test_*trash*.py
pytest -vv tests/unit/with_dbs/**/test_*workspace*.py
  • trash empty workspace and listing
  • api and local deployment (with @odeimaiz )
  • trash workspace with children (discuss with @matusdrobuliak66 )
  • access rights and roles (i.e permissions)(discuss with @matusdrobuliak66 )

Dev-ops

None

@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:api framework api, data schemas, labels Nov 8, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Nov 8, 2024
@pcrespov pcrespov self-assigned this Nov 8, 2024
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 89.66942% with 25 lines in your changes missing coverage. Please review.

Project coverage is 89.38%. Comparing base (1eb6dd0) to head (b373a4b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6690      +/-   ##
==========================================
+ Coverage   88.38%   89.38%   +0.99%     
==========================================
  Files        1545     1361     -184     
  Lines       61619    55192    -6427     
  Branches     2164     1174     -990     
==========================================
- Hits        54462    49333    -5129     
+ Misses       6828     5683    -1145     
+ Partials      329      176     -153     
Flag Coverage Δ
integrationtests 64.78% <64.53%> (+0.01%) ⬆️
unittests 87.06% <89.66%> (+0.77%) ⬆️
Components Coverage Δ
api 78.42% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.17% <90.47%> (+0.02%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.52% <100.00%> (+0.21%) ⬆️
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.41% <ø> (ø)
director_v2 91.13% <ø> (+0.11%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.67% <86.62%> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb6dd0...b373a4b. Read the comment docs.

---- 🚨 Try these New Features:

@pcrespov pcrespov force-pushed the is468/trash-api-workspaces branch 4 times, most recently from 8927e20 to 15b0d4f Compare November 14, 2024 15:56
@pcrespov pcrespov force-pushed the is468/trash-api-workspaces branch 2 times, most recently from a1a972b to 3d3599f Compare November 20, 2024 14:47
@pcrespov pcrespov marked this pull request as ready for review November 20, 2024 20:49
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking very good! Thanks!

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks a lot for the effort.

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the improvements (including the unit tests 💯)

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov force-pushed the is468/trash-api-workspaces branch from 39385f2 to 737f7ae Compare November 21, 2024 17:19
@sonarqubecloud
Copy link

@pcrespov pcrespov enabled auto-merge (squash) November 23, 2024 18:07
@pcrespov pcrespov merged commit 96d7671 into ITISFoundation:master Nov 23, 2024
88 of 90 checks passed
@pcrespov pcrespov deleted the is468/trash-api-workspaces branch November 23, 2024 19:00
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:api framework api, data schemas, a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants