-
Notifications
You must be signed in to change notification settings - Fork 32
✨Computational backend: persist cancellation request #6694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Computational backend: persist cancellation request #6694
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6694 +/- ##
==========================================
+ Coverage 87.95% 89.23% +1.27%
==========================================
Files 1569 1349 -220
Lines 63110 55089 -8021
Branches 2106 979 -1127
==========================================
- Hits 55507 49156 -6351
+ Misses 7278 5778 -1500
+ Partials 325 155 -170
Continue to review full report in Codecov by Sentry.
|
|
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks



What do these changes do?
This PR persists computational job cancellation requests in the DB as a time of the request.
E.g.: when a computational job is marked for cancellation it was only known to the current instance of the director-v2. Therefore if it would restart this information would be lost. This is now fixed.
Driving test:
test_handling_cancellation_of_jobs_after_rebootThis might help with #6400
Related issue/s
How to test
Dev-ops checklist