Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 11, 2024

What do these changes do?

  • adds the client name when connecting to Redis DB
  • in redis-commander (or redis-cli) one can hit client list in the console and see information about the connected clients
  • cleanup of some tests that were not properly shutting down or not properly waiting for async tasks to finish... removed some warnings

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg self-assigned this Nov 11, 2024
@sanderegg sanderegg added a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work labels Nov 11, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 11, 2024
@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (f8f67c9) to head (d5c0613).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6700      +/-   ##
==========================================
+ Coverage   87.10%   87.65%   +0.54%     
==========================================
  Files        1569     1225     -344     
  Lines       63153    53338    -9815     
  Branches     2116      977    -1139     
==========================================
- Hits        55011    46752    -8259     
+ Misses       7817     6402    -1415     
+ Partials      325      184     -141     
Flag Coverage Δ
integrationtests 64.96% <100.00%> (+4.10%) ⬆️
unittests 85.22% <95.00%> (-0.49%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 76.54% <100.00%> (+<0.01%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.17% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.22% <100.00%> (+<0.01%) ⬆️
catalog 89.46% <ø> (ø)
clusters_keeper 98.72% <100.00%> (+<0.01%) ⬆️
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.98% <100.00%> (+5.82%) ⬆️
dynamic_scheduler 96.59% <100.00%> (+<0.01%) ⬆️
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian 90.01% <50.00%> (+0.01%) ⬆️
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (-0.27%) ⬇️
payments 93.02% <ø> (ø)
resource_usage_tracker 90.62% <100.00%> (-0.14%) ⬇️
storage 89.77% <100.00%> (+<0.01%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.71% <100.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f67c9...d5c0613. Read the comment docs.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thanks

@sanderegg sanderegg force-pushed the maintenance/improve-redis-debugging-facilities-and-lock-key-names branch from 9033f31 to 5114dec Compare November 11, 2024 12:07
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sanderegg sanderegg enabled auto-merge (squash) November 11, 2024 12:45
@sanderegg sanderegg force-pushed the maintenance/improve-redis-debugging-facilities-and-lock-key-names branch from 5114dec to e1e4390 Compare November 11, 2024 14:19
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks a lot for the effort!

@sanderegg sanderegg force-pushed the maintenance/improve-redis-debugging-facilities-and-lock-key-names branch 4 times, most recently from af05ded to d5c0613 Compare November 12, 2024 13:29
@sanderegg sanderegg force-pushed the maintenance/improve-redis-debugging-facilities-and-lock-key-names branch from d5c0613 to 087d09e Compare November 12, 2024 14:52
@sanderegg sanderegg disabled auto-merge November 12, 2024 14:52
@sanderegg sanderegg merged commit 0981f49 into ITISFoundation:master Nov 12, 2024
@sanderegg sanderegg deleted the maintenance/improve-redis-debugging-facilities-and-lock-key-names branch November 12, 2024 14:52
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants