-
Notifications
You must be signed in to change notification settings - Fork 32
pydantic2 making ported services green #6701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydantic2 making ported services green #6701
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6701 +/- ##
===============================================================================
- Coverage 74.54% 65.06% -9.49%
===============================================================================
Files 1182 614 -568
Lines 47147 29988 -17159
Branches 1495 349 -1146
===============================================================================
- Hits 35146 19511 -15635
+ Misses 11793 10404 -1389
+ Partials 208 73 -135
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some last comments.
services/dask-sidecar/src/simcore_service_dask_sidecar/settings.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/main.py
Outdated
Show resolved
Hide resolved
...ecar/src/simcore_service_dynamic_sidecar/modules/attribute_monitor/_logging_event_handler.py
Show resolved
Hide resolved
...ecar/src/simcore_service_dynamic_sidecar/modules/attribute_monitor/_logging_event_handler.py
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/datcore_adapter/datcore_adapter_settings.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/isolated/test_application_settings_utils.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/01/clusters/test_clusters_handlers.py
Show resolved
Hide resolved
|
a00d55f
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates


What do these changes do?
osparc-gateway-serverto pedantic2director-v2) compatible greenautoscalingandclusters-keeperthat fails due to errors with the settings have been disabledRelated issue/s
How to test
Dev-ops checklist