-
Notifications
You must be signed in to change notification settings - Fork 32
pydantic2 migration made integration tests green #6719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydantic2 migration made integration tests green #6719
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6719 +/- ##
===============================================================================
+ Coverage 81.13% 87.37% +6.24%
===============================================================================
Files 1530 1522 -8
Lines 63824 60311 -3513
Branches 2226 2148 -78
===============================================================================
+ Hits 51781 52695 +914
+ Misses 11708 7288 -4420
+ Partials 335 328 -7
Continue to review full report in Codecov by Sentry.
|
simcore-sdk and dynamic-sidecar
…quash_updates' into pr-osparc-pydantic2-integration-libraries2
simcore-sdk and dynamic-sidecar
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things
packages/pytest-simcore/src/pytest_simcore/simcore_storage_service.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/tests/integration/test_modules_long_running_tasks.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/exporter/_formatter/xlsx/code_description.py
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments, there are a few left and I think you forgot all the dev.txt and ci.txt files
packages/models-library/src/models_library/api_schemas_catalog/services.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/integration/01/test_garbage_collection.py
Outdated
Show resolved
Hide resolved
packages/dask-task-models-library/src/dask_task_models_library/container_tasks/io.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_catalog/services.py
Outdated
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/models-library/src/models_library/api_schemas_catalog/services.py
Outdated
Show resolved
Hide resolved
…quash_updates' into pr-osparc-pydantic2-integration-libraries2
|
fa57c9e
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates



What do these changes do?
Bonus:
Related issue/s
dy-static-file-serverservices osparc-services#157How to test
Dev-ops checklist