Skip to content

✨ [Frontend] Feature: Announcement generator #6723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 15, 2024
Merged

✨ [Frontend] Feature: Announcement generator #6723

merged 12 commits into from
Nov 15, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 14, 2024 •
edited
Loading

What do these changes do?

In order to ease the generation of the json object that goes in the announcements DB, this PR provides a UI, in the Admin Center, to create them.

Announcement

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 14, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 14, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 14, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 15, 2024

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@odeimaiz odeimaiz marked this pull request as ready for review November 15, 2024 09:26
@odeimaiz odeimaiz enabled auto-merge (squash) November 15, 2024 10:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

GitHK
GitHK reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice: Maybe we should create a few CRUD endpoints for managing these announcements more nicely?

@odeimaiz
Copy link
Member Author

odeimaiz commented Nov 15, 2024

Very nice: Maybe we should create a few CRUD endpoints for managing these announcements more nicely?

Sure, go for it! It would also be nice if you provide CRUD operations on /maintenance

@odeimaiz odeimaiz merged commit e1d940a into ITISFoundation:master Nov 15, 2024
51 checks passed
@odeimaiz odeimaiz deleted the feature/announcement-generator branch November 15, 2024 11:16
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 26, 2024
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@ignapas ignapas ignapas approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@pcrespov pcrespov Awaiting requested review from pcrespov

@mguidon mguidon Awaiting requested review from mguidon

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

4 participants

@odeimaiz @ignapas @GitHK @matusdrobuliak66