Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 15, 2024

What do these changes do?

Versions were not aligned, this PR aligns them for Pydantic v2 and fastapi.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 15, 2024
@giancarloromeo giancarloromeo self-assigned this Nov 15, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review November 15, 2024 11:20
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (a2d3742) to head (d0e60fe).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6730      +/-   ##
===============================================================================
+ Coverage                                        81.15%   81.25%   +0.10%     
===============================================================================
  Files                                             1531     1468      -63     
  Lines                                            63884    61815    -2069     
  Branches                                          2229     1997     -232     
===============================================================================
- Hits                                             51846    50230    -1616     
+ Misses                                           11705    11280     -425     
+ Partials                                           333      305      -28     
Flag Coverage Δ *Carryforward flag
integrationtests 53.36% <ø> (ø) Carriedforward from a2d3742
unittests 85.42% <ø> (+0.30%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.32% <ø> (ø)
pkg_dask_task_models_library 96.61% <ø> (ø)
pkg_models_library 91.23% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.30% <ø> (ø)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 76.42% <ø> (-0.03%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 78.26% <ø> (ø)
agent 97.01% <ø> (ø)
api_server 89.66% <ø> (-0.18%) ⬇️
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 90.87% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 58.43% <ø> (+0.04%) ⬆️
director_v2 76.29% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 59.79% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.74% <ø> (ø)
payments 92.77% <ø> (ø)
resource_usage_tracker 90.61% <ø> (-0.16%) ⬇️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 80.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d3742...d0e60fe. Read the comment docs.

@giancarloromeo giancarloromeo changed the title ⬆️ Align versions for pydantic v2/fastapi ⬆️ Align versions for pydantic/fastapi Nov 15, 2024
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 15, 2024 11:25
@giancarloromeo giancarloromeo merged commit 327beab into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 15, 2024
81 of 89 checks passed
@giancarloromeo giancarloromeo deleted the pydantic-v2-align-versions branch November 15, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants