Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 15, 2024

What do these changes do?

Fixing remaining deprecated stuff.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo changed the base branch from master to pydantic_v2_migration_do_not_squash_updates November 15, 2024 12:46
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (327beab) to head (a7fe6c0).
Report is 3 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6732      +/-   ##
===============================================================================
+ Coverage                                        81.25%   82.62%   +1.37%     
===============================================================================
  Files                                             1531     1530       -1     
  Lines                                            64297    65042     +745     
  Branches                                          2233     2226       -7     
===============================================================================
+ Hits                                             52244    53743    +1499     
+ Misses                                           11719    10964     -755     
- Partials                                           334      335       +1     
Flag Coverage Δ *Carryforward flag
integrationtests 53.38% <ø> (+0.02%) ⬆️ Carriedforward from f4f7b0e
unittests 85.00% <72.72%> (-0.16%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library 93.32% <ø> (ø)
pkg_dask_task_models_library 96.61% <ø> (ø)
pkg_models_library 91.18% <100.00%> (-0.07%) ⬇️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.30% <ø> (-0.14%) ⬇️
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.38% <0.00%> (-0.07%) ⬇️
pkg_settings_library 91.12% <ø> (+0.21%) ⬆️
pkg_simcore_sdk 78.26% <ø> (ø)
agent 97.01% <ø> (ø)
api_server 89.66% <ø> (-0.18%) ⬇️
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 90.87% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 58.38% <ø> (-0.05%) ⬇️
director_v2 88.56% <ø> (+12.26%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 59.79% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.74% <ø> (ø)
payments 92.77% <0.00%> (ø)
resource_usage_tracker 90.76% <ø> (+1.89%) ⬆️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 80.07% <83.33%> (-0.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327beab...a7fe6c0. Read the comment docs.

@giancarloromeo giancarloromeo self-assigned this Nov 15, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 15, 2024
@giancarloromeo giancarloromeo changed the title ♻️ Fix deprecated Pydantic v2 stuff ♻️ Fix deprecated stuff (Pydantic v2) Nov 18, 2024
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo marked this pull request as ready for review November 18, 2024 10:52
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Nov 18, 2024
@giancarloromeo giancarloromeo merged commit 8eac56b into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 18, 2024
1 check passed
@giancarloromeo giancarloromeo deleted the pydantic-v2-fix-deprecated branch November 18, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants