Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 21, 2024

What do these changes do?

Fix the Redis DSN scheme in case the REDIS_SECURE is set to true.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added the a:redis area: redis service label Nov 21, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 21, 2024
@giancarloromeo giancarloromeo self-assigned this Nov 21, 2024
@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (2504277) to head (1657734).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6790      +/-   ##
==========================================
+ Coverage   88.49%   89.92%   +1.42%     
==========================================
  Files        1545     1102     -443     
  Lines       62631    48978   -13653     
  Branches     2155      408    -1747     
==========================================
- Hits        55427    44043   -11384     
+ Misses       6876     4866    -2010     
+ Partials      328       69     -259     
Flag Coverage Δ
integrationtests 67.77% <ø> (-1.04%) ⬇️
unittests 87.14% <ø> (+0.25%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.99% <ø> (ø)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 75.97% <ø> (-0.09%) ⬇️
director_v2 91.42% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.70% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2504277...1657734. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo marked this pull request as ready for review November 21, 2024 11:51
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo enabled auto-merge (squash) November 21, 2024 11:52
@giancarloromeo giancarloromeo merged commit a87de46 into ITISFoundation:master Nov 21, 2024
87 of 90 checks passed
@giancarloromeo giancarloromeo deleted the fix-redis-scheme branch November 21, 2024 12:39
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:redis area: redis service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants