Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 21, 2024

What do these changes do?

Redesign tests inside services/dynamic-sidecar/tests/unit/test_modules_outputs_event_filter.py to avoid flakiness.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Nov 21, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Nov 21, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 21, 2024
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.20%. Comparing base (a87de46) to head (314f45d).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a87de46) and HEAD (314f45d). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (a87de46) HEAD (314f45d)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6795       +/-   ##
===========================================
- Coverage   88.41%   71.20%   -17.21%     
===========================================
  Files        1545      615      -930     
  Lines       61634    30853    -30781     
  Branches     2155      318     -1837     
===========================================
- Hits        54494    21970    -32524     
- Misses       6813     8823     +2010     
+ Partials      327       60      -267     
Flag Coverage Δ
integrationtests 64.76% <75.00%> (-0.01%) ⬇️
unittests 88.77% <100.00%> (+2.45%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.05% <ø> (+0.01%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <100.00%> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.53% <ø> (-29.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87de46...314f45d. Read the comment docs.

---- 🚨 Try these New Features:

@GitHK GitHK changed the title 🐛 Flaky tests 🐛 Fixed flaky dynamic-sidecar test Nov 21, 2024
@GitHK GitHK changed the title 🐛 Fixed flaky dynamic-sidecar test 🐛 Fixed flaky tests in services/dynamic-sidecar/tests/unit/test_modules_outputs_event_filter.py Nov 21, 2024
@GitHK GitHK marked this pull request as ready for review November 21, 2024 14:57
@GitHK GitHK enabled auto-merge (squash) November 21, 2024 14:58
@GitHK GitHK merged commit 5945ea7 into ITISFoundation:master Nov 21, 2024
87 of 90 checks passed
@GitHK GitHK deleted the pr-osparc-investigate-flaky-dy-sidecar-test branch November 21, 2024 15:03
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants