Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Nov 26, 2024

What do these changes do?

  • removing EFS_ONLY_ENABLED_FOR_USERIDS which is not used anymore
  • adding EFS_DEFAULT_USER_SERVICE_SIZE_BYTES to the docker-compose (that was manually added in the production deployment)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 26, 2024
@matusdrobuliak66 matusdrobuliak66 added t:maintenance Some planned maintenance work a:efs-guardian labels Nov 26, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 26, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 26, 2024 10:21
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (dc35757) to head (884d35f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6837      +/-   ##
==========================================
+ Coverage   88.38%   88.41%   +0.02%     
==========================================
  Files        1561     1554       -7     
  Lines       62396    62209     -187     
  Branches     2108     2164      +56     
==========================================
- Hits        55151    54999     -152     
+ Misses       6914     6880      -34     
+ Partials      331      330       -1     
Flag Coverage Δ *Carryforward flag
integrationtests 64.71% <ø> (-3.63%) ⬇️ Carriedforward from 6fc9da1
unittests 86.43% <ø> (+0.10%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.25% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.76% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.13% <ø> (+0.06%) ⬆️
pkg_settings_library 90.60% <ø> (-0.02%) ⬇️
pkg_simcore_sdk 85.36% <ø> (-0.03%) ⬇️
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 90.67% <ø> (-0.07%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.77% <ø> (ø)
resource_usage_tracker 90.71% <ø> (+0.07%) ⬆️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.65% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc35757...884d35f. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget corresponding MRs

@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ Maintenance: removing/adding EFS env vars ♻️ Maintenance: removing/adding EFS env vars ⚠️ Nov 26, 2024
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 26, 2024 19:11
@YuryHrytsuk
Copy link
Contributor

Q:

Why we should merge config PR after this MR is in PROD and not before? This is usually the other way around

@matusdrobuliak66

@matusdrobuliak66
Copy link
Collaborator Author

Q:

Why we should merge config PR after this MR is in PROD and not before? This is usually the other way around

@matusdrobuliak66

Because it is a breaking change if we merge it now. This is the easiest way how to get rid of those vars and do not break anything.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit dfd1463 into ITISFoundation:master Dec 2, 2024
86 of 91 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:efs-guardian t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants