Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 26, 2024

What do these changes do?

ReDoc

The API Keys WebServer's plugin needed some changes (see related issues) and a refactoring.

Please, have a look at the new generated ReDoc... especially in /auth/api-keys endpoints.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Nov 26, 2024
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Nov 26, 2024
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 83.59375% with 42 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (6d1ee29) to head (d9dd232).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6843      +/-   ##
==========================================
- Coverage   88.34%   88.12%   -0.23%     
==========================================
  Files        1571     1416     -155     
  Lines       61649    58295    -3354     
  Branches     2000     1612     -388     
==========================================
- Hits        54462    51370    -3092     
+ Misses       6851     6653     -198     
+ Partials      336      272      -64     
Flag Coverage Δ
integrationtests 65.08% <63.86%> (+0.03%) ⬆️
unittests 86.21% <83.59%> (-0.33%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.12% <100.00%> (+0.04%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 75.50% <0.00%> (-0.34%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.04% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (-0.09%) ⬇️
director_v2 91.36% <100.00%> (-0.03%) ⬇️
dynamic_scheduler 97.14% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.65% <ø> (ø)
resource_usage_tracker 89.24% <ø> (+0.21%) ⬆️
storage 89.60% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.03% <89.94%> (-0.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1ee29...d9dd232. Read the comment docs.

@giancarloromeo giancarloromeo added this to the Event Horizon milestone Dec 3, 2024
@giancarloromeo giancarloromeo added the t:enhancement Improvement or request on an existing feature label Dec 3, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good. Lets just agree on the naming convention 👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few observations

@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo merged commit 34374b4 into ITISFoundation:master Dec 10, 2024
87 of 93 checks passed
@giancarloromeo giancarloromeo deleted the refactor-api-keys-service branch December 10, 2024 09:13
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:enhancement Improvement or request on an existing feature

Projects

None yet

7 participants