-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ Refactor API-keys service #6843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor API-keys service #6843
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6843 +/- ##
==========================================
- Coverage 88.34% 88.12% -0.23%
==========================================
Files 1571 1416 -155
Lines 61649 58295 -3354
Branches 2000 1612 -388
==========================================
- Hits 54462 51370 -3092
+ Misses 6851 6653 -198
+ Partials 336 272 -64
Continue to review full report in Codecov by Sentry.
|
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
services/web/server/src/simcore_service_webserver/api_keys/_repository.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/api_keys/_repository.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/api_keys/_repository.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/api_keys/_repository.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/api_keys/_service.py
Outdated
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/models-library/src/models_library/api_schemas_webserver/auth.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/auth.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/auth.py
Show resolved
Hide resolved
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Looks good. Lets just agree on the naming convention 👍
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few observations
services/web/server/src/simcore_service_webserver/api_keys/_repository.py
Outdated
Show resolved
Hide resolved
|



What do these changes do?
The
API KeysWebServer's plugin needed some changes (see related issues) and a refactoring.Please, have a look at the new generated ReDoc... especially in
/auth/api-keysendpoints.Related issue/s
How to test
Dev-ops checklist