-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fix *Urls serialization
#6852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix *Urls serialization
#6852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6852 +/- ##
==========================================
+ Coverage 86.61% 89.38% +2.77%
==========================================
Files 1491 1261 -230
Lines 59914 53241 -6673
Branches 2166 973 -1193
==========================================
- Hits 51896 47592 -4304
+ Misses 7701 5503 -2198
+ Partials 317 146 -171
Continue to review full report in Codecov by Sentry.
|
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
|



What do these changes do?
After migration to Pydantic v2, all
*Urls are notstranymore. This causes issues when serializing objects with fields of these types.This PR enhances the
json_dumpsmethod to reproduce the previous behavior serializing all the*Urls new types asstr.Actually the error occurred was:
Related issue/s
How to test
Dev-ops checklist