🐛 Fix Decimal serialization

[giancarloromeo]

What do these changes do?

Pydatic v2 serializes Decimals as strings to avoid loss of precision derived from conversion to float. This PR reverts the partial changes made during the migration.

Related issue/s

• See: 🐛 [Frontend] pydanticV2: Decimals are now Strings #6853

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (81e5b8e) to head (e2d4696).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6854      +/-   ##
==========================================
+ Coverage   88.33%   89.20%   +0.87%     
==========================================
  Files        1553     1268     -285     
  Lines       61193    53074    -8119     
  Branches     2095      874    -1221     
==========================================
- Hits        54055    47347    -6708     
+ Misses       6806     5591    -1215     
+ Partials      332      136     -196     

Flag	Coverage Δ
integrationtests	65.25% <ø> (+0.10%)	⬆️
unittests	87.29% <100.00%> (+0.78%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	91.21% <100.00%> (-0.01%)	⬇️
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	70.00% <ø> (ø)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	85.38% <ø> (ø)
agent	97.00% <ø> (ø)
api_server	89.81% <ø> (ø)
autoscaling	95.21% <ø> (ø)
catalog	90.57% <ø> (ø)
clusters_keeper	98.72% <ø> (ø)
dask_sidecar	91.26% <ø> (ø)
datcore_adapter	93.17% <ø> (ø)
director	76.49% <ø> (ø)
director_v2	91.37% <ø> (-0.08%)	⬇️
dynamic_scheduler	97.01% <ø> (ø)
dynamic_sidecar	89.72% <ø> (-0.04%)	⬇️
efs_guardian	90.12% <ø> (ø)
invitations	93.44% <ø> (ø)
osparc_gateway_server	80.05% <ø> (∅)
payments	92.77% <ø> (ø)
resource_usage_tracker	89.07% <ø> (-0.08%)	⬇️
storage	89.66% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	87.89% <ø> (-0.38%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e5b8e...e2d4696. Read the comment docs.

[pcrespov]

This change affects some models in the web api schema. Can you please, cd web/server and

1. increase minor version make minor-version
2. update openapi specs make openapi-specs

[bisgaard-itis]

Can you please wait a bit with merging this one? This will break the api-server. It essentially reverts the changes I did in https://github.com/ITISFoundation/osparc-simcore/pull/6658/files in order to make the api-server as "backwards compatible as possible". I am confident your changes should go in. But it would be nice to have a strategy for how to handle this in the api-server before this breaks it. I will discuss with @pcrespov tomorrow how to handle this. Sorry for the inconvenience.

[bisgaard-itis]

Can you please wait a bit with merging this one? This will break the api-server. It essentially reverts the changes I did in https://github.com/ITISFoundation/osparc-simcore/pull/6658/files in order to make the api-server as "backwards compatible as possible". I am confident your changes should go in. But it would be nice to have a strategy for how to handle this in the api-server before this breaks it. I will discuss with @pcrespov tomorrow how to handle this. Sorry for the inconvenience.

I am a bit scared by the fact that you don't see here that you are breaking backwards compatibility of the api-server. I think I will set up a hook so people see that they are breaking our interface

[pcrespov]

@bisgaard-itis @giancarloromeo I will temporary block it to avoid accidental merging. Let me know if this is a problem for you! :-)

[giancarloromeo]

@pcrespov @bisgaard-itis The related PR (#6853) is already in.

[bisgaard-itis]

OK, this one can go in for me. I will have to handle the backwards compatibility directly in the api-server. I am half way there and this should be quite easy to handle. @pcrespov I believe you can also approve this one

[bisgaard-itis]

Could you please also update the api-server's openapi.json in this PR?

cd services/api-server
make install-dev
make openapi.json

[bisgaard-itis]

Thanks a lot for the effort.

[pcrespov]

Discussed with @bisgaard-itis . It does not affect backwards compatibility f the api-server

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud