Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 28, 2024

What do these changes do?

Enables trash entrypoitns in web-api

Related issue/s

How to test

Dev-ops checklist

None

@pcrespov pcrespov self-assigned this Nov 28, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Nov 28, 2024
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Nov 28, 2024
@pcrespov pcrespov changed the title WIP: Is468/trash enabled 🎨 Enables trash in web-api Nov 28, 2024
@pcrespov pcrespov marked this pull request as ready for review November 28, 2024 11:12
@codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (42711d9) to head (42fb176).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (42711d9) and HEAD (42fb176). Click for more details.

HEAD has 27 uploads less than BASE
Flag BASE (42711d9) HEAD (42fb176)
unittests 31 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6861      +/-   ##
==========================================
- Coverage   88.39%   82.15%   -6.25%     
==========================================
  Files        1550      619     -931     
  Lines       61779    30909   -30870     
  Branches     2110      263    -1847     
==========================================
- Hits        54607    25392   -29215     
+ Misses       6842     5457    -1385     
+ Partials      330       60     -270     
Flag Coverage Δ *Carryforward flag
integrationtests 64.74% <ø> (-0.03%) ⬇️ Carriedforward from 57b7c60
unittests 87.14% <75.00%> (+0.72%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.53% <ø> (-14.51%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.96%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.64% <75.00%> (-0.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42711d9...42fb176. Read the comment docs.

@pcrespov pcrespov force-pushed the is468/trash-enabled branch from cba86cd to 28b9aa7 Compare November 28, 2024 15:08
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 277cf70 into ITISFoundation:master Nov 29, 2024
85 of 90 checks passed
@pcrespov pcrespov deleted the is468/trash-enabled branch November 29, 2024 08:56
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants