⬆️ Upgrades deprecated pydantic calls repo-wide #6864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
requested review from
giancarloromeo,
matusdrobuliak66 and
sanderegg
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6864 +/- ##
==========================================
- Coverage 88.39% 88.37% -0.03%
==========================================
Files 1550 1550
Lines 61768 61769 +1
Branches 2110 2110
==========================================
- Hits 54602 54590 -12
- Misses 6835 6848 +13
Partials 331 331
Continue to review full report in Codecov by Sentry.
|
sanderegg
approved these changes
Nov 29, 2024
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
thanks!
please have a look at my comment regarding json_dumps.
...ges/models-library/src/models_library/function_services_catalog/services/iter_sensitivity.py
Show resolved
Hide resolved
|
GitHK
approved these changes
Nov 29, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Based on the
PydanticDeprecatedSince20warnings shown in the model-library tests, I upgrades repo-wise some pydantic calls.Removed some outdated docs 📝 and makefile recipes 🔨
Related issue/s
How to test
Dev-ops checklist
None