Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 2, 2024

What do these changes do?

  • fixes a few issues appearing while testing director-v2 regarding pydantic V2 and SQLAlchemy V2

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Dec 2, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Dec 2, 2024
@sanderegg sanderegg self-assigned this Dec 2, 2024
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.16%. Comparing base (931595e) to head (7675722).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (931595e) and HEAD (7675722). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (931595e) HEAD (7675722)
unittests 30 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6877       +/-   ##
===========================================
- Coverage   88.33%   69.16%   -19.17%     
===========================================
  Files        1525      655      -870     
  Lines       61066    32366    -28700     
  Branches     2108      262     -1846     
===========================================
- Hits        53941    22387    -31554     
- Misses       6794     9919     +3125     
+ Partials      331       60      -271     
Flag Coverage Δ *Carryforward flag
integrationtests 68.34% <ø> (-0.01%) ⬇️ Carriedforward from 931595e
unittests 86.29% <100.00%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 98.72% <ø> (-0.01%) ⬇️
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 90.64% <100.00%> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.57% <ø> (-29.11%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931595e...7675722. Read the comment docs.

@sanderegg sanderegg force-pushed the pydantic-v2/serialized-value-may-not-be branch from d71be47 to 177bfb1 Compare December 2, 2024 13:04
@sanderegg sanderegg marked this pull request as ready for review December 2, 2024 13:04
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the pydantic-v2/serialized-value-may-not-be branch from 177bfb1 to 3f211d1 Compare December 2, 2024 15:24
@sanderegg sanderegg enabled auto-merge (squash) December 2, 2024 15:25
@sanderegg sanderegg force-pushed the pydantic-v2/serialized-value-may-not-be branch from 3f211d1 to 7675722 Compare December 2, 2024 16:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

@sanderegg sanderegg merged commit dc35757 into ITISFoundation:master Dec 2, 2024
86 of 91 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants