Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 2, 2024

⚠️ devops

What do these changes do?

Using better options for rclone which should enhance performance.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Dec 2, 2024
@GitHK GitHK added a:dynamic-sidecar dynamic-sidecar service a:agent agent service labels Dec 2, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 2, 2024
@GitHK GitHK marked this pull request as ready for review December 2, 2024 17:00
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (7b5cba8) to head (6b3a943).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6885      +/-   ##
==========================================
+ Coverage   88.31%   89.41%   +1.09%     
==========================================
  Files        1553     1125     -428     
  Lines       61193    48650   -12543     
  Branches     2095      354    -1741     
==========================================
- Hits        54045    43502   -10543     
+ Misses       6817     5078    -1739     
+ Partials      331       70     -261     
Flag Coverage Δ
integrationtests 65.06% <100.00%> (+0.01%) ⬆️
unittests 87.30% <100.00%> (+0.80%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <100.00%> (ø)
agent 97.00% <ø> (ø)
api_server 89.81% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.49% <ø> (+0.08%) ⬆️
director_v2 90.51% <ø> (-0.86%) ⬇️
dynamic_scheduler 97.01% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 79.79% <ø> (∅)
payments 92.77% <ø> (ø)
resource_usage_tracker 89.07% <ø> (+0.29%) ⬆️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 87.92% <ø> (-0.34%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5cba8...6b3a943. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget the MRs. thanks!

@GitHK GitHK changed the title ♻️ adjust rclone defaults ♻️ adjust rclone defaults ⚠️ Dec 3, 2024
@GitHK GitHK enabled auto-merge (squash) December 3, 2024 07:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

@GitHK GitHK merged commit e317f6b into ITISFoundation:master Dec 5, 2024
87 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-extend-rclone-options branch December 5, 2024 05:21
@GitHK GitHK mentioned this pull request Jan 9, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:agent agent service a:dynamic-sidecar dynamic-sidecar service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RClone options tuning

4 participants