-
Notifications
You must be signed in to change notification settings - Fork 32
✨ [Frontend] Username and Privacy settings #6916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for a this round but I think we should need to polish some details.
Here are some thoughts:
- Capitalize
Usernamesame as you do with first and last name. - When if fails, i have to improve the message and perhaps we can offer alternative usernames that are similar to the one the user enters.
- I would also add more info on what is what (e.g. a small info icon or on hover on each field). Specially for privacy.
- We also need to elaborate a bit more what are the implications of the privacy settings on the overall sharing etc ...
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I capitalized |
|



What do these changes do?
This PR exposes
usernamefor other usersRelated issue/s
How to test
Dev-ops checklist