Skip to content

🐛♻️ web-api: fixes adding group member by user-name and some cleanup #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 11, 2024
Merged

🐛♻️ web-api: fixes adding group member by user-name and some cleanup #6940

merged 12 commits into from
Dec 11, 2024

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Dec 11, 2024 •
edited
Loading

What do these changes do?

ReDoc

Following manual testing on the master deployment, we identified a use-case that was still not fully functional. This PR addresses the issue with a fix (including additional test coverage) and incorporates some simple (but noisy) cleanup refactoring in the groups domain.

  • 🐛 Fixes add_group_user with userName:
  • ♻️ Refactoring and Cleanup:
    • Moved GroupID to models_library.groups for better modularization.
    • Unified GroupType for both ORM and domain models by relocating it to common_library.groups_enum.
    • 🐛 Fixes migration service Dockerfile. Did not include new dependency with common_library)

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/01/groups/test_groups_handlers_users.py -m acceptance_test

@pcrespov pcrespov added a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work a:models-library labels Dec 11, 2024
@pcrespov pcrespov self-assigned this Dec 11, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Dec 11, 2024
@pcrespov pcrespov changed the title Mai/groupid import 🐛♻️ web-api: fixes adding group member by user-name and some cleanup Dec 11, 2024
@pcrespov pcrespov marked this pull request as ready for review December 11, 2024 15:04
@pcrespov pcrespov requested a review from odeimaiz December 11, 2024 15:04
@codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.09091% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.97%. Comparing base (e94782d) to head (df7cf56).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6940      +/-   ##
==========================================
- Coverage   88.07%   87.97%   -0.10%     
==========================================
  Files        1589     1600      +11     
  Lines       62233    62483     +250     
  Branches     2012     2045      +33     
==========================================
+ Hits        54810    54969     +159     
- Misses       7087     7167      +80     
- Partials      336      347      +11
Flag Coverage Δ
integrationtests 65.01% <88.23%> (+0.06%) ⬆️
unittests 86.20% <84.09%> (-0.10%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.24% <100.00%> (-0.01%) ⬇️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.05% <100.00%> (-0.02%) ⬇️
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 74.58% <ø> (ø)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.04% <100.00%> (ø)
autoscaling 95.42% <ø> (ø)
catalog 90.57% <50.00%> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.38% <ø> (+0.02%) ⬆️
dynamic_scheduler 96.99% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <100.00%> (+<0.01%) ⬆️
resource_usage_tracker 89.58% <ø> (+0.26%) ⬆️
storage 89.61% <100.00%> (+<0.01%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.74% <88.23%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94782d...df7cf56. Read the comment docs.

sanderegg
sanderegg approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@pcrespov pcrespov enabled auto-merge (squash) December 11, 2024 17:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov disabled auto-merge December 11, 2024 21:59
@pcrespov pcrespov merged commit 08981e0 into ITISFoundation:master Dec 11, 2024
90 of 93 checks passed
@pcrespov pcrespov deleted the mai/groupid-import branch December 11, 2024 22:00
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 12, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

Assignees

@pcrespov pcrespov

Labels

a:database associated to postgres service and postgres-database package a:models-library t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

5 participants

@pcrespov @giancarloromeo @GitHK @odeimaiz @sanderegg