Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 11, 2024

What do these changes do?

Rerouted get project inactivity command via dynamic-scheduler.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Dec 11, 2024
@GitHK GitHK added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:dynamic-scheduler labels Dec 11, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 11, 2024
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.84%. Comparing base (d75b0a3) to head (6612d10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6949      +/-   ##
==========================================
- Coverage   87.02%   86.84%   -0.19%     
==========================================
  Files        1621     1451     -170     
  Lines       63967    60223    -3744     
  Branches     2034     1645     -389     
==========================================
- Hits        55669    52300    -3369     
+ Misses       7965     7652     -313     
+ Partials      333      271      -62     
Flag Coverage Δ
integrationtests 64.98% <50.00%> (+<0.01%) ⬆️
unittests 85.03% <80.00%> (-0.29%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.55% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.22% <0.00%> (-0.13%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (-0.09%) ⬇️
director_v2 91.46% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.19% <100.00%> (+0.04%) ⬆️
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.56% <ø> (+0.23%) ⬆️
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.33% <75.00%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75b0a3...6612d10. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review December 12, 2024 08:20
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically the same question as in #6943 (review)

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the explanation.

@GitHK GitHK enabled auto-merge (squash) December 18, 2024 08:17
@sonarqubecloud
Copy link

@GitHK GitHK merged commit 68f0b24 into ITISFoundation:master Dec 20, 2024
87 of 93 checks passed
@GitHK GitHK deleted the pr-osparc-reroute-get-project-inactivity branch December 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dynamic-scheduler a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

redirect get_project_inactivity call via dynamic-scheduler

5 participants