- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
✨ Get and search users applying privacy settings 🗃️ #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #6966      +/-   ##
==========================================
+ Coverage   87.02%   88.73%   +1.71%     
==========================================
  Files        1621     1407     -214     
  Lines       63993    56174    -7819     
  Branches     2035     1034    -1001     
==========================================
- Hits        55688    49847    -5841     
+ Misses       7972     6152    -1820     
+ Partials      333      175     -158     
 
 Continue to review full report in Codecov by Sentry. 
  | 
    
7eaf541    to
    031d39d      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you need to regenerate the openapi specs. as the test is failing
        
          
                .../simcore_postgres_database/migration/versions/58012c1e1b1b_set_privacy_hide_email_to_true.py
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
        
          
                services/web/server/src/simcore_service_webserver/users/_users_rest.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/users/_users_rest.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      ae95280    to
    c94a135      
    Compare
  
    c94a135    to
    733ecdd      
    Compare
  
    
          
 | 
    



What do these changes do?
username,emailorfirst/last_name(if privacy settings allows):POST /users:searchwithmatchandlimitin request bodyprimary_group_id:GET /groups/{primary_group_id}/usersby(wont be used)user_id:GET users/{user_id}/usersto/admin/userssince it was used for admin purposesRelated issue/s
usersdomain for improved layer separation and upgrading to asyncpg #6937How to test
test_get_and_search_public_usersDev-ops
None