Skip to content

♻️Computation backend: clean comp_tasks DB (🗃️) #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 17, 2024
Merged

♻️Computation backend: clean comp_tasks DB (🗃️) #6968

merged 9 commits into from
Dec 17, 2024

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 16, 2024 •
edited
Loading

What do these changes do?

  • removes "submit" column in comp_tasks

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Dec 16, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Dec 16, 2024
@sanderegg sanderegg self-assigned this Dec 16, 2024
@codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (38866c1) to head (200a6d1).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6968      +/-   ##
==========================================
+ Coverage   85.56%   87.10%   +1.53%     
==========================================
  Files        1611     1604       -7     
  Lines       63638    63442     -196     
  Branches     2027     2027              
==========================================
+ Hits        54455    55261     +806     
+ Misses       8849     7848    -1001     
+ Partials      334      333       -1
Flag Coverage Δ
integrationtests 64.54% <75.00%> (-0.01%) ⬇️
unittests 85.09% <100.00%> (+0.88%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.36% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.26% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 74.22% <ø> (+0.07%) ⬆️
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.41% <100.00%> (-0.03%) ⬇️
dynamic_scheduler 97.14% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.65% <ø> (+0.06%) ⬆️
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.39% <ø> (+4.81%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38866c1...200a6d1. Read the comment docs.

pcrespov
pcrespov approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHK
GitHK approved these changes Dec 16, 2024
View reviewed changes
matusdrobuliak66
matusdrobuliak66 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Please do not forget DB migration icon in the name 🗃️

@sanderegg sanderegg changed the title ♻️Computation backend: clean comp_tasks DB ♻️Computation backend: clean comp_tasks DB (🗃️) Dec 16, 2024
@sanderegg sanderegg force-pushed the computation-backend/clean-dbs branch 5 times, most recently from 5070345 to 225df27 Compare December 17, 2024 12:20
@sanderegg sanderegg enabled auto-merge (squash) December 17, 2024 12:20
@sanderegg sanderegg force-pushed the computation-backend/clean-dbs branch from 225df27 to fc76b80 Compare December 17, 2024 13:48
@sanderegg sanderegg force-pushed the computation-backend/clean-dbs branch from fc76b80 to 200a6d1 Compare December 17, 2024 20:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 8f4c1b2 into ITISFoundation:master Dec 17, 2024
92 of 93 checks passed
@sanderegg sanderegg mentioned this pull request Jan 6, 2025
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2025
Closed
14 tasks
@sanderegg sanderegg deleted the computation-backend/clean-dbs branch January 9, 2025 06:47
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @GitHK @pcrespov @matusdrobuliak66