Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • 🐛 add ProjectInvalidRightsError to folders exception handling (before it returned 500)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 18, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Dec 18, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Dec 18, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 18, 2024 13:09
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 18, 2024 13:12
@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.33%. Comparing base (89c8472) to head (3e977b0).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (89c8472) and HEAD (3e977b0). Click for more details.

HEAD has 25 uploads less than BASE
Flag BASE (89c8472) HEAD (3e977b0)
unittests 29 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6979      +/-   ##
==========================================
- Coverage   85.58%   80.33%   -5.25%     
==========================================
  Files        1621      649     -972     
  Lines       63939    31675   -32264     
  Branches     2033      262    -1771     
==========================================
- Hits        54720    25447   -29273     
+ Misses       8886     6168    -2718     
+ Partials      333       60     -273     
Flag Coverage Δ
integrationtests 64.86% <100.00%> (+0.31%) ⬆️
unittests 84.83% <100.00%> (+0.47%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.77% <ø> (-12.63%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 84.41% <100.00%> (+4.56%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c8472...3e977b0. Read the comment docs.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 48d3fba into ITISFoundation:master Dec 18, 2024
89 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants