Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Dec 23, 2024

What do these changes do?

Solve serialization warnings like the following, mainly caused by a misuse of model_construct method:

 Expected `Author` but got `dict` with value `{'name': 'nodetails', '[email protected]'}` - serialized value may not be as expected
 Expected `Author` but got `dict` with value `{'name': 'nodetails', '[email protected]'}` - serialized value may not be as expected
 Expected `Author` but got `dict` with value `{'name': 'nodetails', '[email protected]'}` - serialized value may not be as expected
 Expected `Author` but got `dict` with value `{'name': 'nodetails', '[email protected]'}` - serialized value may not be as expected
 Expected `Author` but got `dict` with value `{'name': 'nodetails', '[email protected]'}` - serialized value may not be as expected
 Expected `Author` but got `dict` with value `{'name': 'nodetails', '[email protected]'}` - serialized value may not be as expected

The problem affects both CI (with tests executions) and deployed systems, flooding logs with these messages.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Dec 23, 2024
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Dec 23, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Dec 23, 2024
@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (6f0c82c) to head (e86abb2).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6f0c82c) and HEAD (e86abb2). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (6f0c82c) HEAD (e86abb2)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6992       +/-   ##
===========================================
- Coverage   86.99%   65.74%   -21.25%     
===========================================
  Files        1621      696      -925     
  Lines       64051    33275    -30776     
  Branches     2035      262     -1773     
===========================================
- Hits        55720    21877    -33843     
- Misses       7997    11338     +3341     
+ Partials      334       60      -274     
Flag Coverage Δ
integrationtests 64.86% <ø> (-3.10%) ⬇️
unittests 90.57% <100.00%> (+5.27%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 90.57% <100.00%> (+<0.01%) ⬆️
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.77% <ø> (-12.64%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.16% <ø> (-25.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0c82c...e86abb2. Read the comment docs.

@giancarloromeo giancarloromeo mentioned this pull request Dec 23, 2024
7 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

@giancarloromeo giancarloromeo marked this pull request as ready for review January 6, 2025 10:58
@giancarloromeo giancarloromeo merged commit 300e242 into ITISFoundation:master Jan 6, 2025
98 of 103 checks passed
@giancarloromeo giancarloromeo deleted the fix-pydantic-serialization-warns branch January 24, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants