-
Notifications
You must be signed in to change notification settings - Fork 32
🎨🐛 [Frontend] Copyright with current year #6996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| return "REGISTER"; | ||
| }, | ||
|
|
||
| getCopyrightLink: function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts:
what is copyright date used for?
- the year in a copyright footnote is a crucial piece of information that identifies the creation or publication date of the work, thereby clarifying its copyright status and duration.
- The year indicates when the copyright was claimed or began.
- The copyright duration in most countries is based on the life of the author plus a specific number of years (e.g., 70 years in the US and EU). However, for corporate or anonymous works, it may be a fixed term starting from the date of publication. The year helps calculate when the copyright will expire.
Therefore:
- There is no need to change the copyright to the latest year all the time
- I understand that this provides an easy and fast fix but I think it is a bad practice to override the information provided by the PO in the backend. Some alternatives are:
-
- Provide a
product.vendor.copyrightnote as a template string e.g.$(year) ITIS-Foundationis variable but2024 ITIS-Foundationis fixed year
- Provide a
-
- Compose copyright note from vendor fields instead of a having a dedicated entry for it. Therefore we drop
copyrightand add an optionalcopyrightYearand if not provided you add the latest.
- Compose copyright note from vendor fields instead of a having a dedicated entry for it. Therefore we drop
-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't have a strong opinion on this one, it was reported in the team chat and this was a fix. Shall we leave to the POs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not even think this might be an issue if you ask the POs.
I would ask. Write here the answer (and who answered you) and resolve it fast within this PR.
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would also consider whether that date must be changed. or maybe it should be published date instead.
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR might have been generated out of confusion. I remember a discussion about it, but was not aware about the copyright implications.



What do these changes do?
In order to keep up with the current year in the copyright text, in this PR the frontend tunes the copyright text coming from the vendor's information:
DB:

Frontend:

Related issue/s
How to test
Dev-ops checklist