Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 3, 2025

What do these changes do?

In order to keep up with the current year in the copyright text, in this PR the frontend tunes the copyright text coming from the vendor's information:

  • remove the copyright symbol, if any
  • remove the year prefix, if any
  • add the copyright and current year

DB:
image

Frontend:
image

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jan 3, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 3, 2025 10:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jan 3, 2025
@odeimaiz odeimaiz added this to the Event Horizon milestone Jan 3, 2025
@odeimaiz odeimaiz changed the title 🎨🐛 [Frontend] Copyright Links with current year 🎨🐛 [Frontend] Copyright with current year Jan 3, 2025
@odeimaiz odeimaiz enabled auto-merge (squash) January 3, 2025 11:15
return "REGISTER";
},

getCopyrightLink: function() {
Copy link
Member

@pcrespov pcrespov Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts:

what is copyright date used for?

  • the year in a copyright footnote is a crucial piece of information that identifies the creation or publication date of the work, thereby clarifying its copyright status and duration.
  • The year indicates when the copyright was claimed or began.
  • The copyright duration in most countries is based on the life of the author plus a specific number of years (e.g., 70 years in the US and EU). However, for corporate or anonymous works, it may be a fixed term starting from the date of publication. The year helps calculate when the copyright will expire.

Therefore:

  • There is no need to change the copyright to the latest year all the time
  • I understand that this provides an easy and fast fix but I think it is a bad practice to override the information provided by the PO in the backend. Some alternatives are:
      1. Provide a product.vendor.copyright note as a template string e.g. $(year) ITIS-Foundation is variable but 2024 ITIS-Foundation is fixed year
      1. Compose copyright note from vendor fields instead of a having a dedicated entry for it. Therefore we drop copyright and add an optional copyrightYear and if not provided you add the latest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't have a strong opinion on this one, it was reported in the team chat and this was a fix. Shall we leave to the POs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not even think this might be an issue if you ask the POs.
I would ask. Write here the answer (and who answered you) and resolve it fast within this PR.

@odeimaiz odeimaiz disabled auto-merge January 3, 2025 14:10
@odeimaiz odeimaiz requested a review from YuryHrytsuk January 3, 2025 14:12
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would also consider whether that date must be changed. or maybe it should be published date instead.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR might have been generated out of confusion. I remember a discussion about it, but was not aware about the copyright implications.

@odeimaiz odeimaiz closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants