Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 6, 2025

What do these changes do?

Legacy services that have a node ports package integrated still rely on the old schemas of the comp_tasks table.
This PR re-adds the deprecated column with a default of 1st Jan 1900.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:database associated to postgres service and postgres-database package label Jan 6, 2025
@sanderegg sanderegg added this to the Event Horizon milestone Jan 6, 2025
@sanderegg sanderegg self-assigned this Jan 6, 2025
@sanderegg sanderegg requested review from GitHK and odeimaiz January 6, 2025 12:57
@codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (fee208d) to head (378269e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7003      +/-   ##
==========================================
+ Coverage   86.92%   88.40%   +1.48%     
==========================================
  Files        1630     1405     -225     
  Lines       64378    56255    -8123     
  Branches     2035      893    -1142     
==========================================
- Hits        55959    49734    -6225     
+ Misses       8086     6366    -1720     
+ Partials      333      155     -178     
Flag Coverage Δ
integrationtests 64.84% <100.00%> (+1.36%) ⬆️
unittests 87.20% <100.00%> (+1.98%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.58% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.23% <ø> (ø)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (-0.09%) ⬇️
director_v2 91.40% <100.00%> (+0.02%) ⬆️
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.56% <ø> (ø)
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.16% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee208d...378269e. Read the comment docs.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the bugfixes/7000/add-submit-column-back branch 2 times, most recently from f3e5484 to 924c072 Compare January 6, 2025 15:33
@sanderegg sanderegg enabled auto-merge (squash) January 6, 2025 16:35
@sanderegg sanderegg disabled auto-merge January 6, 2025 17:01
@sanderegg sanderegg enabled auto-merge (squash) January 6, 2025 17:01
@sanderegg sanderegg force-pushed the bugfixes/7000/add-submit-column-back branch from 924c072 to 378269e Compare January 6, 2025 17:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sanderegg sanderegg merged commit 4659473 into ITISFoundation:master Jan 7, 2025
91 of 93 checks passed
@sanderegg sanderegg deleted the bugfixes/7000/add-submit-column-back branch January 7, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:database associated to postgres service and postgres-database package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-add a dummy submit column in comp_tasks as this is needed by the legacy services

6 participants