Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jan 7, 2025

What do these changes do?

⚠️ This PR is the first step of a complete migration of workbench data from the projects table to the projects_nodes one (some parts might be refined later in next steps).

New columns are added to target table (i.e. projects_nodes) and existing data are copied as part of an Alembic migration.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Jan 7, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jan 7, 2025
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Jan 7, 2025
@giancarloromeo giancarloromeo added a:database associated to postgres service and postgres-database package a:director-v2 issue related with the director-v2 service labels Jan 7, 2025
@giancarloromeo giancarloromeo changed the title ♻️ Extract Projects workbench data 🗃️ WIP: ♻️ Extract Projects workbench data 🗃️ Jan 7, 2025
@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 91.13924% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.68%. Comparing base (272671c) to head (5ece129).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7010      +/-   ##
==========================================
+ Coverage   87.66%   87.68%   +0.02%     
==========================================
  Files        1632     1626       -6     
  Lines       63663    63524     -139     
  Branches     2050     2050              
==========================================
- Hits        55810    55701     -109     
+ Misses       7516     7486      -30     
  Partials      337      337              
Flag Coverage Δ
integrationtests 67.96% <41.40%> (+3.16%) ⬆️
unittests 85.95% <85.44%> (+0.01%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.43% <84.61%> (-0.03%) ⬇️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.41% <100.00%> (+0.09%) ⬆️
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 74.13% <ø> (ø)
pkg_settings_library 90.49% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.42% <ø> (-0.09%) ⬇️
director_v2 91.40% <ø> (+0.11%) ⬆️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.39% <ø> (ø)
invitations 93.42% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.06% <ø> (+0.11%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.17% <90.62%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272671c...5ece129. Read the comment docs.

@giancarloromeo giancarloromeo changed the title WIP: ♻️ Extract Projects workbench data 🗃️ WIP: ♻️ Extract Projects workbench to external table 🗃️ Jan 7, 2025
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo merged commit 6e92682 into ITISFoundation:master Jan 21, 2025
91 of 93 checks passed
@giancarloromeo giancarloromeo deleted the is5646/extract-projects-workbench-column branch January 21, 2025 17:31
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:database associated to postgres service and postgres-database package a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants