-
Notifications
You must be signed in to change notification settings - Fork 32
♻️Maintenance: Refactoring of redis client structure #7015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Maintenance: Refactoring of redis client structure #7015
Conversation
c4d65eb to
06b48a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7015 +/- ##
==========================================
- Coverage 86.91% 86.51% -0.41%
==========================================
Files 1638 1636 -2
Lines 64621 64343 -278
Branches 2041 2041
==========================================
- Hits 56166 55666 -500
- Misses 8115 8339 +224
+ Partials 340 338 -2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
|



What do these changes do?
Related issue/s
prior to fixing #6668 this very noisy PR refactors the redis client code so that it is more maintainable.
NOTE no changes of functionality here
Bonuses:
How to test
Dev-ops checklist