Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 8, 2025

What do these changes do?

Related issue/s

prior to fixing #6668 this very noisy PR refactors the redis client code so that it is more maintainable.

NOTE no changes of functionality here

Bonuses:

  • upgraded redis to 5.2.1 repository wide
  • upgraded pycln to latest in pre-commit hooks
  • next step with regard to automatically building for ARM64 architecture

How to test

Dev-ops checklist

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Jan 8, 2025
@sanderegg sanderegg added this to the Event Horizon milestone Jan 8, 2025
@sanderegg sanderegg self-assigned this Jan 8, 2025
@sanderegg sanderegg force-pushed the bugfixes/redis-lock-failing branch from c4d65eb to 06b48a7 Compare January 8, 2025 08:40
@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 90.68323% with 15 lines in your changes missing coverage. Please review.

Project coverage is 86.51%. Comparing base (324c053) to head (a1f69fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7015      +/-   ##
==========================================
- Coverage   86.91%   86.51%   -0.41%     
==========================================
  Files        1638     1636       -2     
  Lines       64621    64343     -278     
  Branches     2041     2041              
==========================================
- Hits        56166    55666     -500     
- Misses       8115     8339     +224     
+ Partials      340      338       -2     
Flag Coverage Δ
integrationtests 67.71% <83.33%> (+3.24%) ⬆️
unittests 84.82% <90.68%> (-0.01%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.58% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.27% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.87% <91.60%> (+0.28%) ⬆️
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <100.00%> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <100.00%> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (-0.09%) ⬇️
director_v2 91.41% <75.00%> (+0.01%) ⬆️
dynamic_scheduler 97.19% <100.00%> (ø)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.12% <33.33%> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.50% <100.00%> (-0.06%) ⬇️
storage 89.59% <100.00%> (+0.05%) ⬆️
webclient ∅ <ø> (∅)
webserver 82.64% <100.00%> (-1.44%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324c053...a1f69fd. Read the comment docs.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

@sanderegg sanderegg merged commit 897cfca into ITISFoundation:master Jan 8, 2025
92 of 93 checks passed
@sanderegg sanderegg deleted the bugfixes/redis-lock-failing branch January 8, 2025 10:37
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants