🐛🎨 [Frontend] Reduce number of (unnecessary) PATCH calls at Study open #7019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
mrnicegyu11,
pcrespov and
sanderegg
pcrespov
approved these changes
Jan 9, 2025
odeimaiz
changed the title
giancarloromeo
approved these changes
Jan 9, 2025
matusdrobuliak66
approved these changes
Jan 9, 2025
|
ignapas
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When opening a study with many nodes, each node used to make a Patch call setting some defaults values. When dealing with studies with many nodes, this step could make the start up slower and some calls could even time out, showing the scary "Error saving study" message. This PR fixes/improves this start up step.
Bonus:
accessRightsin frontend's cache after patching other metadata @matusdrobuliak66Before:
After:
Related issue/s
How to test
Dev-ops checklist