Skip to content

🎨 [Frontend] Show trashedAt and trashedBy on Bin cards #7030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jan 20, 2025
Merged

🎨 [Frontend] Show trashedAt and trashedBy on Bin cards #7030

merged 29 commits into from
Jan 20, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 13, 2025 •
edited
Loading

What do these changes do?

Show trashedAt and trashedBy (for now only available on Workspaces, Folders and Studies coming soon) on Bin cards.

TrashedAtAndBy

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jan 13, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Jan 13, 2025
@odeimaiz odeimaiz self-assigned this Jan 13, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Show trashed at date 🎨 [Frontend] Enh: Show trashedAt date Jan 13, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Show trashedAt date 🎨 [Frontend] Enh: Show trashedAt and trashedBy on Bin items Jan 17, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Show trashedAt and trashedBy on Bin items 🎨 [Frontend] Show trashedAt and trashedBy on Bin items Jan 17, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Show trashedAt and trashedBy on Bin items 🎨 [Frontend] Show trashedAt and trashedBy on Bin cards Jan 17, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 17, 2025 16:25
matusdrobuliak66
matusdrobuliak66 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍

@pcrespov pcrespov mentioned this pull request Jan 17, 2025
Merged
pcrespov
pcrespov approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the api is also ready!

sanderegg
sanderegg reviewed Jan 19, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@odeimaiz odeimaiz enabled auto-merge (squash) January 20, 2025 09:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ignapas
ignapas approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename "Bin" to "Recently deleted"

@odeimaiz odeimaiz merged commit eb35a48 into ITISFoundation:master Jan 20, 2025
55 checks passed
jsaq007
jsaq007 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz deleted the enh/show-trashed-at-date branch January 20, 2025 12:01
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 30, 2025
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg left review comments

@ignapas ignapas ignapas approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@GitHK GitHK Awaiting requested review from GitHK

+1 more reviewer

@jsaq007 jsaq007 jsaq007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

6 participants

@odeimaiz @jsaq007 @ignapas @pcrespov @sanderegg @matusdrobuliak66