-
Notifications
You must be signed in to change notification settings - Fork 32
✨ web-api: trashed resources include trashedBy with the primary GID of the user that trashed it
#7052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7052 +/- ##
==========================================
+ Coverage 87.16% 87.56% +0.40%
==========================================
Files 1634 1626 -8
Lines 64264 63616 -648
Branches 2051 2053 +2
==========================================
- Hits 56013 55706 -307
+ Misses 7914 7573 -341
Partials 337 337
Continue to review full report in Codecov by Sentry.
|
47c5c0a to
d6856bf
Compare
trashedBy with the primary GID of the user that trashed it
trashedBy with the primary GID of the user that trashed ittrashedBy with the primary GID of the user that trashed it
67fb6bb to
9a1b399
Compare
trashedBy with the primary GID of the user that trashed ittrashedBy with the primary GID of the user that trashed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! just update the PR description.
packages/models-library/src/models_library/api_schemas_webserver/folders_v2.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/folders_v2.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_projects_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_projects_db.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have left some comments 👍
packages/models-library/src/models_library/api_schemas_webserver/folders_v2.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/folders/_folders_repository.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_projects_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_workspaces_repository.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks
packages/pytest-simcore/src/pytest_simcore/simcore_webserver_projects_rest_api.py
Outdated
Show resolved
Hide resolved
e8627d6 to
8e025e1
Compare
c502d7b to
1340862
Compare
|



What do these changes do?
Any resource that was trashed (so far
projects,foldersorworkspace) includes whentrashedAt: datetimeand whotrashedBy: GroupIDtrashedAtandtrashedByon Bin cards #7030foldersandworkspaceto fit CSR architecture.Related issue/s
trashedAtandtrashedByon Bin cards #7030How to test
Dev-ops
None