🎨 [Frontend] Search users as they type #7037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
…rc-simcore into enh/search-users-as-i-type
odeimaiz
requested review from
GitHK,
SCA-ZMT,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
matusdrobuliak66
approved these changes
Jan 14, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
👍 We should improve the search with Fuzzy package Postgres plugin, as was proposed by Pedro.
giancarloromeo
approved these changes
Jan 14, 2025
pcrespov
approved these changes
Jan 14, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
nice.
Did you check if I delete? i.e. start typing 3 ... then delete one ...
|
ignapas
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
After seeing that the
users:searchcall is not an expensive one, in this PR the search-users-as-you-type was implemented.Related issue/s
How to test
Dev-ops checklist