Skip to content

🐛 [e2e] click the first New Launcher button #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2025
Merged

🐛 [e2e] click the first New Launcher button #7039

merged 3 commits into from
Jan 14, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 14, 2025 •
edited
Loading

What do these changes do?

In the latest jupyter-smash there are 2 "New Launcher" buttons, this PR fixes the e2e by clicking the first match.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jan 14, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing labels Jan 14, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Jan 14, 2025
@codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (082ec0b) to head (bfca47d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7039      +/-   ##
==========================================
- Coverage   86.95%   86.84%   -0.12%     
==========================================
  Files        1651     1651              
  Lines       64811    64811              
  Branches     2041     2041              
==========================================
- Hits        56358    56283      -75     
- Misses       8116     8191      +75     
  Partials      337      337
Flag Coverage Δ *Carryforward flag
integrationtests 64.84% <ø> (+1.39%) ⬆️
unittests 85.16% <ø> (ø) Carriedforward from b4d405b

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.58% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.27% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.95% <ø> (ø)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.57% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.57% <ø> (ø)
director_v2 91.35% <ø> (ø)
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.56% <ø> (ø)
storage 89.59% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 83.69% <ø> (-0.37%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082ec0b...bfca47d. Read the comment docs.

@odeimaiz odeimaiz changed the title 🐛 [e2e] take the first matching button 🐛 [e2e] click the first() New Launcher button Jan 14, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 14, 2025 11:33
@odeimaiz odeimaiz changed the title 🐛 [e2e] click the first() New Launcher button 🐛 [e2e] click the first New Launcher button Jan 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

giancarloromeo
giancarloromeo approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfetto 👌

@odeimaiz odeimaiz enabled auto-merge (squash) January 14, 2025 11:46
@odeimaiz odeimaiz merged commit adb1867 into ITISFoundation:master Jan 14, 2025
92 of 93 checks passed
@odeimaiz odeimaiz deleted the fix-e2e/new-laounchers branch January 14, 2025 12:30
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov

Assignees

@odeimaiz odeimaiz

Labels

bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

5 participants

@odeimaiz @giancarloromeo @GitHK @sanderegg @matusdrobuliak66