Skip to content

🐛 [e2e] click the first New Launcher button #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025
Merged

🐛 [e2e] click the first New Launcher button #7039

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4d405b
take the first matching button
odeimaiz Jan 14, 2025
e750ed7
one more
odeimaiz Jan 14, 2025
bfca47d
first() -> nth(0)
odeimaiz Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/e2e-playwright/tests/jupyterlabs/test_jupyterlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def test_jupyterlab(
logging.INFO,
f"Creating multiple files and 1 file of about {large_file_size.human_readable()}",
):
iframe.get_by_role("button", name="New Launcher").click()
iframe.get_by_role("button", name="New Launcher").nth(0).click()
with page.expect_websocket(_JLabWaitForTerminalWebSocket()) as ws_info:
iframe.get_by_label("Launcher").get_by_text("Terminal").click()

Expand Down Expand Up @@ -153,7 +153,7 @@ def test_jupyterlab(
return
# Wait until iframe is shown and create new notebook with print statement
with log_context(logging.INFO, "Running new notebook"):
iframe.get_by_role("button", name="New Launcher").click()
iframe.get_by_role("button", name="New Launcher").nth(0).click()
iframe.locator(".jp-LauncherCard-icon").first.click()
iframe.get_by_role("tab", name="Untitled.ipynb").click()
_jupyterlab_ui = iframe.get_by_label("Untitled.ipynb").get_by_role("textbox")
Expand Down
Loading