🐛 OSPARC_API_BASE_URL variable ends with /

[sanderegg]

What do these changes do?

strip ending / from URL

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[giancarloromeo]

What about changing the DIRECTOR_V2_PUBLIC_API_BASE_URL field in AppSettings class like so:

DIRECTOR_V2_PUBLIC_API_BASE_URL: Annotated[AnyHttpUrl | str, AfterValidator(lambda v: str(v).rstrip("/")), Field(
    ...,
    description="Base URL used to access the public api e.g. http://127.0.0.1:6000 for development or https://api.osparc.io",
)]

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.12%. Comparing base (99746e4) to head (ceb9150).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (99746e4) and HEAD (ceb9150). Click for more details.

HEAD has 25 uploads less than BASE

Flag	BASE (99746e4)	HEAD (ceb9150)
unittests	26	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #7042       +/-   ##
===========================================
- Coverage   82.33%   69.12%   -13.21%     
===========================================
  Files        1465      662      -803     
  Lines       57456    32207    -25249     
  Branches     1295      262     -1033     
===========================================
- Hits        47304    22262    -25042     
+ Misses       9965     9885       -80     
+ Partials      187       60      -127     

Flag	Coverage Δ
integrationtests	63.76% <75.00%> (+5.18%)	⬆️
unittests	84.61% <75.00%> (+2.27%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.37% <ø> (+11.72%)	⬆️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	91.31% <75.00%> (+5.72%)	⬆️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	89.75% <ø> (ø)
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
osparc_gateway_server	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	57.60% <ø> (-14.67%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99746e4...ceb9150. Read the comment docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud