🐛Autoscaling: Fix issue where all warm buffers would be used to replace hot buffers (🚨) #7079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
force-pushed
the
autoscaling/bugfix/scale-up-warm-buffer-too-much
branch
from
f7447e3 to
711ff6d
Compare
sanderegg
requested review from
GitHK,
YuryHrytsuk,
giancarloromeo,
matusdrobuliak66,
mguidon and
mrnicegyu11
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7079 +/- ##
==========================================
- Coverage 87.26% 87.19% -0.08%
==========================================
Files 1634 1627 -7
Lines 64262 64074 -188
Branches 2051 2051
==========================================
- Hits 56078 55868 -210
- Misses 7848 7869 +21
- Partials 336 337 +1
Continue to review full report in Codecov by Sentry.
|
sanderegg
changed the title
15 tasks
GitHK
approved these changes
Jan 24, 2025
sanderegg
force-pushed
the
autoscaling/bugfix/scale-up-warm-buffer-too-much
branch
from
711ff6d to
ff27450
Compare
matusdrobuliak66
approved these changes
Jan 24, 2025
|
sanderegg
deleted the
autoscaling/bugfix/scale-up-warm-buffer-too-much
branch
matusdrobuliak66
pushed a commit
that referenced
this pull request
Jan 24, 2025
…ce hot buffers (🚨) (#7079)
This was referenced Jan 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
After #6929 changes, a missing hot buffer would be replaced by a warm buffer if possible.
A bug in the implementation of this feature had for consequence that all the available warm buffers would be started to replace 1 missing hot buffer which leads to:
driving test:
test_warm_buffers_only_replace_hot_buffer_if_service_is_started_issue7071@matusdrobuliak66 @YuryHrytsuk This should be hotfixed
Related issue/s
How to test
Dev-ops checklist