Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 29, 2025

What do these changes do?

  • Added a new optional email field in the product for product owners.
  • This email is used as the primary contact for account requests; if not provided, the request defaults to the required support email.

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit -k test_request_an_account

Dev-ops

  • 🚨 when released, please review the product config and provide product_owners_email if applies.

@pcrespov pcrespov self-assigned this Jan 29, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jan 29, 2025
@pcrespov pcrespov added this to the Singularity milestone Jan 29, 2025
@pcrespov pcrespov force-pushed the is7130/change-email-registration branch from 40078fc to e3f5899 Compare January 29, 2025 10:24
@pcrespov pcrespov marked this pull request as ready for review January 29, 2025 10:24
@pcrespov pcrespov changed the title Is7130/change email registration 🎨 New PO email per product to use in account requests Jan 29, 2025
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pcrespov pcrespov changed the title 🎨 New PO email per product to use in account requests 🎨 New PO email per product to use in account requests πŸ—ƒοΈπŸš¨ Jan 29, 2025
@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 87.70%. Comparing base (b3641d9) to head (1588318).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7131      +/-   ##
==========================================
+ Coverage   86.16%   87.70%   +1.53%     
==========================================
  Files        1635     1628       -7     
  Lines       63871    63682     -189     
  Branches     2053     2053              
==========================================
+ Hits        55034    55851     +817     
+ Misses       8500     7494    -1006     
  Partials      337      337              
Flag Coverage Ξ”
integrationtests 64.69% <66.66%> (+0.04%) ⬆️
unittests 85.97% <100.00%> (+1.74%) ⬆️
Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library 93.49% <ΓΈ> (ΓΈ)
pkg_dask_task_models_library 97.09% <ΓΈ> (ΓΈ)
pkg_models_library 91.33% <ΓΈ> (ΓΈ)
pkg_notifications_library 84.57% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.39% <ΓΈ> (ΓΈ)
pkg_service_integration 70.18% <ΓΈ> (ΓΈ)
pkg_service_library 74.14% <ΓΈ> (ΓΈ)
pkg_settings_library 90.71% <ΓΈ> (ΓΈ)
pkg_simcore_sdk 85.38% <ΓΈ> (ΓΈ)
agent 96.46% <ΓΈ> (ΓΈ)
api_server 90.55% <ΓΈ> (ΓΈ)
autoscaling 96.08% <ΓΈ> (ΓΈ)
catalog 90.33% <ΓΈ> (ΓΈ)
clusters_keeper 99.24% <ΓΈ> (ΓΈ)
dask_sidecar 91.26% <ΓΈ> (ΓΈ)
datcore_adapter 93.19% <ΓΈ> (ΓΈ)
director 76.92% <ΓΈ> (ΓΈ)
director_v2 91.30% <ΓΈ> (+0.04%) ⬆️
dynamic_scheduler 97.21% <ΓΈ> (ΓΈ)
dynamic_sidecar 89.75% <ΓΈ> (ΓΈ)
efs_guardian 90.25% <ΓΈ> (ΓΈ)
invitations 93.28% <ΓΈ> (ΓΈ)
osparc_gateway_server βˆ… <ΓΈ> (βˆ…)
payments 92.66% <ΓΈ> (ΓΈ)
resource_usage_tracker 89.06% <ΓΈ> (+0.05%) ⬆️
storage 89.57% <ΓΈ> (ΓΈ)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 86.24% <100.00%> (+5.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b3641d9...1588318. Read the comment docs.

@pcrespov pcrespov enabled auto-merge (squash) January 29, 2025 10:38
@sonarqubecloud
Copy link

@pcrespov pcrespov disabled auto-merge January 29, 2025 11:13
@pcrespov pcrespov enabled auto-merge (squash) January 29, 2025 11:13
@pcrespov pcrespov disabled auto-merge January 29, 2025 11:52
@pcrespov pcrespov merged commit b3fb639 into ITISFoundation:master Jan 29, 2025
94 checks passed
@pcrespov pcrespov deleted the is7130/change-email-registration branch January 29, 2025 11:53
@pcrespov
Copy link
Member Author

βœ… tested in master

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change mail recipient

4 participants