Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 29, 2025

What do these changes do?

In our CI pipeline there are tests that fail but will still make the unit-tests, integration-tests and system-tests be green. This did not allow Mergify's Workflow Automation to restart the CI.
Added all the edge cases that could make the restart not occur.

Instead of manually enqueuing the PRs, Mergify will now add them automatically once conditions are met.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 29, 2025
@GitHK GitHK added the t:enhancement Improvement or request on an existing feature label Jan 29, 2025
@GitHK GitHK added this to the Singularity milestone Jan 29, 2025
@GitHK GitHK marked this pull request as ready for review January 29, 2025 11:48
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

MINOR, the correct icon is 🔨 Add or update development scripts.. and tag it as t:maintenance so we can account for it in the stats

@GitHK GitHK added t:maintenance Some planned maintenance work and removed t:enhancement Improvement or request on an existing feature labels Jan 29, 2025
@GitHK GitHK changed the title 🎨 Allow Mergify to detect more failing cases for restoring the CI 🔨 Allow Mergify to detect more failing cases for restoring the CI Jan 29, 2025
@GitHK GitHK changed the title 🔨 Allow Mergify to detect more failing cases for restoring the CI 🔨 Allow Mergify to detect more failing cases for CI restarts & Automatically add PRs to queue Jan 29, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are re-writing the github workflow file.. is this not contraproductive?

@sanderegg sanderegg force-pushed the pr-osparc-mergify-extra-condtions branch from 5301a70 to 3012c30 Compare January 30, 2025 10:45
@sanderegg sanderegg merged commit b50e7e8 into ITISFoundation:master Jan 30, 2025
3 of 4 checks passed
@sonarqubecloud
Copy link

@GitHK GitHK deleted the pr-osparc-mergify-extra-condtions branch January 30, 2025 10:47
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants