Skip to content

Conversation

@YuryHrytsuk
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk commented Jan 30, 2025

What do these changes do?

  • Update traefik router hardcoded priorities according to the rules below
    • 1 --> 3
    • 2 --> 6
    • 3 --> 9
  • Remove unnecessary priority from manual service

This PR introduces some space in-between the routers which we can use to flexibly add new routers. It shouldn't break existing priority hierarchy since numbers <10 are still below any other non-hardcoded priorities.

Remarks for future:

  • Whenever introducing some priorities to traefik routers (or other similar cases) one better to make them spacious to retain flexibility. This case is a good example why "spacious" approach makes sense

Related issue/s

Related PRs

How to test

Dev-ops checklist

@YuryHrytsuk YuryHrytsuk added the t:enhancement Improvement or request on an existing feature label Jan 30, 2025
@YuryHrytsuk YuryHrytsuk added this to the Singularity milestone Jan 30, 2025
@YuryHrytsuk YuryHrytsuk requested review from GitHK and pcrespov January 30, 2025 08:21
@YuryHrytsuk YuryHrytsuk self-assigned this Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.72%. Comparing base (c681035) to head (3527bf0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7141      +/-   ##
==========================================
+ Coverage   87.69%   87.72%   +0.02%     
==========================================
  Files        1635     1628       -7     
  Lines       63875    63685     -190     
  Branches     1173     1173              
==========================================
- Hits        56015    55866     -149     
+ Misses       7550     7510      -40     
+ Partials      310      309       -1     
Flag Coverage Δ
integrationtests 64.66% <ø> (ø)
unittests 86.01% <ø> (+0.02%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.50% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <ø> (ø)
pkg_service_integration 70.18% <ø> (ø)
pkg_service_library 74.44% <ø> (+0.05%) ⬆️
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (-0.09%) ⬇️
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.73% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.18% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681035...3527bf0. Read the comment docs.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@sonarqubecloud
Copy link

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you know what you are doing ;)

@YuryHrytsuk YuryHrytsuk merged commit 65e1ab2 into ITISFoundation:master Jan 30, 2025
90 of 93 checks passed
@YuryHrytsuk YuryHrytsuk deleted the update-traefik-router-hardcoded-priorities branch January 30, 2025 09:27
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants