Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 30, 2025

What do these changes do?

Fixes e2e test workflows:

  • sim4life start
  • sim4life-lite start

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jan 30, 2025
@sonarqubecloud
Copy link

@odeimaiz odeimaiz changed the title 🐛 [e2e] fixes after new plus button 🐛 [e2e] Fixes after new plus button Jan 30, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 30, 2025 10:34
@odeimaiz odeimaiz added bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing labels Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (65e1ab2) to head (91cc9e6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7143   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files        1635     1635           
  Lines       63875    63875           
  Branches     1173     1173           
=======================================
  Hits        56014    56014           
  Misses       7551     7551           
  Partials      310      310           
Flag Coverage Δ *Carryforward flag
integrationtests 64.70% <ø> (ø)
unittests 85.98% <ø> (ø) Carriedforward from 65e1ab2

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.50% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <ø> (ø)
pkg_service_integration 70.18% <ø> (ø)
pkg_service_library 74.39% <ø> (ø)
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 77.01% <ø> (ø)
director_v2 91.27% <ø> (ø)
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.79% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.20% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e1ab2...91cc9e6. Read the comment docs.

@odeimaiz odeimaiz requested a review from sanderegg January 30, 2025 10:38
@sanderegg sanderegg merged commit f2b568f into ITISFoundation:master Jan 30, 2025
90 of 91 checks passed
@odeimaiz odeimaiz deleted the fix/e2e-new-plus-button branch January 30, 2025 10:39
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants