Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 3, 2025

What do these changes do?

Since RedisClientsManager initiates more than one connection towards Redis it also creates multiple health checks which hit the server concurrently.

Related issue/s

How to test

Dev-ops checklist

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (15d54a6) to head (134eae7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7156      +/-   ##
==========================================
- Coverage   87.69%   87.62%   -0.08%     
==========================================
  Files        1635     1276     -359     
  Lines       63939    53987    -9952     
  Branches     1176      651     -525     
==========================================
- Hits        56074    47304    -8770     
+ Misses       7554     6504    -1050     
+ Partials      311      179     -132     
Flag Coverage Δ
integrationtests 64.65% <ø> (-0.03%) ⬇️
unittests 85.60% <100.00%> (-0.40%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 74.43% <100.00%> (+0.03%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (-0.09%) ⬇️
director_v2 91.30% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (-0.06%) ⬇️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.21% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d54a6...134eae7. Read the comment docs.

@GitHK
Copy link
Contributor Author

GitHK commented Feb 3, 2025

Since redis is made to handle up to a million requests per second. I do not agree with this change. https://redis.io/docs/latest/develop/get-started/faq/#:~:text=Redis%20can%20handle%20up%20to,available%20memory%20in%20your%20system

@GitHK GitHK closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant