Skip to content

Add licensing endpoints to api check and improve backwards compatibility checks #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Add licensing endpoints to api check and improve backwards compatibility checks #7157

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ee7c33f
add license endpoints to openapi.json
bisgaard-itis Feb 3, 2025
14db6ee
use exact commit to compare openapi specs
bisgaard-itis Feb 3, 2025
5080910
minor fix
bisgaard-itis Feb 3, 2025
1467c25
improve run description
bisgaard-itis Feb 3, 2025
a4fff24
use github.sha to get commit
bisgaard-itis Feb 3, 2025
efce34f
small test
bisgaard-itis Feb 3, 2025
92c976e
yet another small test
bisgaard-itis Feb 3, 2025
cfd945a
use the after field to get hash
bisgaard-itis Feb 3, 2025
d90ab69
merge master into 7099-improve-backwards-compatibility-checks
bisgaard-itis Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/ci-testing-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,16 @@ jobs:
enable-cache: false
- name: checkout source branch
uses: actions/checkout@v4
- name: Regenerate specs and check
- name: Generate openapi specs
run: |
make devenv
source .venv/bin/activate
make openapi-specs
- name: Check openapi specs are up to date
run: |
echo "github.event.after=${{ github.event.after }}"
if ! ./ci/github/helpers/openapi-specs-diff.bash diff \
https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/refs/heads/${{ github.event.pull_request.head.ref }} \
https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/${{ github.event.after }} \
.; then \
echo "::error:: OAS are not up to date. Run 'make openapi-specs' to update them"; exit 1; \
fi
Expand All @@ -57,7 +60,7 @@ jobs:
- name: check api-server backwards compatibility
run: |
./scripts/openapi-diff.bash breaking --fail-on ERR\
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }}/services/api-server/openapi.json \
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/${{ github.sha }}/services/api-server/openapi.json \
/specs/services/api-server/openapi.json

all-oas-breaking:
Expand All @@ -76,5 +79,5 @@ jobs:
- name: Check openapi-specs backwards compatibility
run: |
./ci/github/helpers/openapi-specs-diff.bash breaking \
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }} \
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/${{ github.sha }} \
.
Loading
Loading