Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 4, 2025

What do these changes do?

Adds catalog client to dynamic-scheduler. Note: this client is not currently used.

Related issue/s

How to test

Dev-ops checklist ⚠️

@GitHK GitHK self-assigned this Feb 4, 2025
@GitHK GitHK added this to the Singularity milestone Feb 4, 2025
@GitHK GitHK changed the title ✨ Adding catalog client to dynamic-scheduler ✨ Adding catalog client to dynamic-scheduler ⚠️ Feb 4, 2025
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.04%. Comparing base (dd342a3) to head (522ff8c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7162      +/-   ##
==========================================
+ Coverage   82.71%   87.04%   +4.32%     
==========================================
  Files        1355     1647     +292     
  Lines       55239    64245    +9006     
  Branches      826     1095     +269     
==========================================
+ Hits        45692    55923   +10231     
+ Misses       9293     8010    -1283     
- Partials      254      312      +58     
Flag Coverage Δ
integrationtests 65.30% <ø> (-0.07%) ⬇️
unittests 86.03% <100.00%> (+3.48%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (∅)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.53% <ø> (∅)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.25% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.54% <ø> (+0.05%) ⬆️
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (∅)
datcore_adapter 93.19% <ø> (∅)
director 76.59% <ø> (ø)
director_v2 91.26% <ø> (+12.38%) ⬆️
dynamic_scheduler 97.33% <100.00%> (+0.14%) ⬆️
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (∅)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (∅)
resource_usage_tracker 88.73% <ø> (-0.06%) ⬇️
storage 86.22% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.79% <ø> (+5.44%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd342a3...522ff8c. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review February 4, 2025 11:38
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is there no RPC entrypoint instead of using REST?

@GitHK GitHK enabled auto-merge (squash) February 12, 2025 12:21
@sonarqubecloud
Copy link

@GitHK GitHK merged commit b0edf43 into ITISFoundation:master Feb 12, 2025
94 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-add-catalog-client-to-dynamic-scheduler branch February 12, 2025 13:12
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requirement: add catalog client to dynamic-scheduler

6 participants