Skip to content

🎨 [Frontend] Enh: Tags UX #7169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 5, 2025
Merged

🎨 [Frontend] Enh: Tags UX #7169

merged 20 commits into from
Feb 5, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 5, 2025 •
edited
Loading

What do these changes do?

After adding 50 tags in production, some UX flaws arised.

  • Scroll container for the Tags
  • Active Tags listed first
  • Show all active Tags in Study Details
  • Show ellipses if more than three tags on Study Card

Before:
TagsOld

After:
TagsNew

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 5, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Feb 5, 2025
@odeimaiz odeimaiz self-assigned this Feb 5, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 5, 2025 14:23
@odeimaiz odeimaiz enabled auto-merge (squash) February 5, 2025 14:27
GitHK
GitHK approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

matusdrobuliak66
matusdrobuliak66 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ I wonder if someone would go over the limits you tested ... (practically, not just for fun)

ignapas
ignapas reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the study details window, where the assigned tags are shown, would it be possible to remove the horizontal scroll and make them flow like text, taking the available width?

@odeimaiz
Copy link
Member Author

odeimaiz commented Feb 5, 2025

In the study details window, where the assigned tags are shown, would it be possible to remove the horizontal scroll and make them flow like text, taking the available width?

Exactly, that was the Before, we now moved to the After ;)

ignapas
ignapas approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry, great!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 4653f36 into ITISFoundation:master Feb 5, 2025
56 checks passed
@odeimaiz odeimaiz deleted the enh/tag-handling branch February 5, 2025 19:46
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 7, 2025
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@odeimaiz @mrnicegyu11
🎨 [Frontend] Enh: Tags UX (ITISFoundation#7169)
f793f48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ignapas ignapas ignapas approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

Tags: Collapse tags in study button when they do not fit

5 participants

@odeimaiz @ignapas @GitHK @pcrespov @matusdrobuliak66