Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 6, 2025

What do these changes do?

Do not show node inputs/settings in App Mode. Also updated the tip test to make sure settings are not visible

Before:
Before

After:
After

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz changed the title Fix/app mode setting 🐛 [Frontend] Bugfix: App Mode was showing the settings Feb 6, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 6, 2025 13:18
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (cfe66a5) to head (17a2765).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7180      +/-   ##
==========================================
- Coverage   87.05%   86.98%   -0.07%     
==========================================
  Files        1646     1642       -4     
  Lines       64297    64926     +629     
  Branches     1186     1176      -10     
==========================================
+ Hits        55971    56478     +507     
- Misses       8014     8140     +126     
+ Partials      312      308       -4     
Flag Coverage Δ *Carryforward flag
integrationtests 63.96% <ø> (+0.62%) ⬆️
unittests 86.35% <ø> (+1.01%) ⬆️ Carriedforward from 05eea4b

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.01% <ø> (-0.01%) ⬇️
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.39% <ø> (-0.18%) ⬇️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <ø> (+0.14%) ⬆️
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 73.99% <ø> (+1.05%) ⬆️
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.68% <ø> (+0.17%) ⬆️
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (-0.01%) ⬇️
autoscaling 96.08% <ø> (ø)
catalog 91.24% <ø> (-0.48%) ⬇️
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.86% <ø> (+0.27%) ⬆️
director_v2 91.29% <ø> (ø)
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 89.75% <ø> (-0.04%) ⬇️
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.06% <ø> (+0.43%) ⬆️
storage 89.68% <ø> (+3.39%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.09% <ø> (-0.70%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe66a5...17a2765. Read the comment docs.

@odeimaiz odeimaiz enabled auto-merge (squash) February 6, 2025 15:39
@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit d432c6c into ITISFoundation:master Feb 10, 2025
89 of 94 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants